Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-11727: Reenable no-floating-promises rule #50

Merged
merged 1 commit into from
Jan 13, 2025
Merged

TINY-11727: Reenable no-floating-promises rule #50

merged 1 commit into from
Jan 13, 2025

Conversation

ltrouton
Copy link
Contributor

Related Ticket: TINY-11727

Description of Changes:

  • Turn no-floating-promises rule back on as it is useful to catch potential async issues

Pre-checks:

  • Changelog entry added
  • package.json version bumped (if first change of new major/minor)
  • Tests have been added (if applicable)

@ltrouton ltrouton requested review from a team, TheSpyder, kimwoodfield, tiny-ben-tran and shanmen-tiny and removed request for a team January 13, 2025 00:42
@ltrouton ltrouton requested review from a team as code owners January 13, 2025 00:42
@ltrouton ltrouton merged commit fd2f906 into main Jan 13, 2025
5 checks passed
@ltrouton ltrouton deleted the feature/TINY-11727 branch January 13, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemister85 kemister85 kemister85 approved these changes

@tiny-ben-tran tiny-ben-tran tiny-ben-tran approved these changes

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder was automatically assigned from tinymce/editor-platform-team

@kimwoodfield kimwoodfield Awaiting requested review from kimwoodfield kimwoodfield was automatically assigned from tinymce/editor-platform-team

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny shanmen-tiny was automatically assigned from tinymce/editor-platform-team

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@jscasca jscasca Awaiting requested review from jscasca jscasca is a code owner automatically assigned from tinymce/integrations-team

@FarzadHayat FarzadHayat Awaiting requested review from FarzadHayat FarzadHayat is a code owner automatically assigned from tinymce/integrations-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltrouton @kemister85 @tiny-ben-tran