fix(memory): sanitize fts5 user queries#2531
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR adds FTS query sanitization across the unified memory store module. A shared ChangesFTS Query Sanitization
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@graycyrus @senamakel Ready for review. Latest state for #2531 (fix(memory): sanitize fts5 user queries):
|
Summary
MATCHqueries.Problem
MATCH.fts5: syntax error, after which the higher-level memory query path degrades into empty results/log-only warnings.Solution
episodic_searchnow trims and sanitizes user input before executing the FTS5MATCHquery.event_search_ftsreuses the same sanitizer so event memory search handles punctuation consistently.Submission Checklist
diff-cover) meet the gate enforced by.github/workflows/coverage.yml. Targeted Rust regression tests exercise the changed search paths; CI Coverage Gate remains authoritative.## Related— N/A: no matrix feature ID changed.docs/RELEASE-MANUAL-SMOKE.md) — N/A: no release smoke checklist surface changed.Closes #NNNin the## Relatedsection — N/A: 为何我让它检查github 最近两天我的动作,执行超过数小时没有结果? #2478 has broader GitHub delegation and memory-ingestion scope; this PR fixes one concrete root cause only.Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/2478-fts5-query-sanitizer2fd03e526d853d3516fb44092f14c94e0554b74bValidation Run
pnpm --filter openhuman-app format:check— N/A: no frontend files changed.pnpm typecheck— N/A: no TypeScript files changed.GGML_NATIVE=OFF cargo test --manifest-path Cargo.toml memory::store::unified::fts5 --lib;GGML_NATIVE=OFF cargo test --manifest-path Cargo.toml memory::store::unified::events --lib;GGML_NATIVE=OFF cargo test --manifest-path Cargo.toml memory::store::unified::query --libcargo fmt --manifest-path Cargo.toml --all;git diff --check;GGML_NATIVE=OFF cargo check --manifest-path Cargo.tomlValidation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
Ok(Vec::new()), matching existing empty-search behavior.Duplicate / Superseded PR Handling
fix/2478-fts5-query-sanitizer.Summary by CodeRabbit
Bug Fixes
Tests