Skip to content

[feature] added temperature reading to esp32s3#5398

Open
Wikwoj0512 wants to merge 1 commit into
tinygo-org:devfrom
Wikwoj0512:esp32s3-temperature
Open

[feature] added temperature reading to esp32s3#5398
Wikwoj0512 wants to merge 1 commit into
tinygo-org:devfrom
Wikwoj0512:esp32s3-temperature

Conversation

@Wikwoj0512
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this into src/machine/machine_esp32s3? I don't see a reason why this needs a separate file (we already have a whole load of files in the src/machine directory).

Other than that, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants