[feature] added flash support analogous to esp32c3 to esp32s3#5397
Open
Wikwoj0512 wants to merge 1 commit into
Open
[feature] added flash support analogous to esp32c3 to esp32s3#5397Wikwoj0512 wants to merge 1 commit into
Wikwoj0512 wants to merge 1 commit into
Conversation
aykevl
reviewed
May 27, 2026
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
Looks reasonable, though I didn't check the modifications to esp32s3.ld. Can someone else also take a look?
| } | ||
|
|
||
| // WriteAt writes the given number of bytes to the block device. | ||
| // Only word (32 bits) length data can be programmed. |
Member
There was a problem hiding this comment.
// Only word (32 bits) length data can be programmed.
Did you check whether this is also true for the ESP32S3? I couldn't easily find it in the SDK: https://docs.espressif.com/projects/esp-idf/en/v6.0.1/esp32s3/api-reference/peripherals/spi_flash/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.