Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf528xx: add advertiser random address #328

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

deadprogram
Copy link
Member

This PR adds an Advertiser SetRandomAddress() function to the nrf528xx in the same way that it was added in the PR #325 that this PR is based on.

This is needed in order to implement the FindMy style beacons.

gap.go Show resolved Hide resolved
Copy link
Contributor

@ysoldak ysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please check my comment.
Just a sanity check, you know better how it supposed to work.
Also, this PR seem to add more than it advertises in the title. Shall be fine as long as we merge with rebase to keep individual commits.

@deadprogram deadprogram force-pushed the xudongzheng-hci-rand-addr-pr branch 2 times, most recently from f2ec9bf to 1db1de6 Compare January 9, 2025 08:55
Base automatically changed from xudongzheng-hci-rand-addr-pr to dev January 9, 2025 09:00
…nInd, to leave room for FindMy data

Signed-off-by: deadprogram <[email protected]>
…pe passed into the SoftDevice struct for API call

Signed-off-by: deadprogram <[email protected]>
@deadprogram deadprogram force-pushed the nrf528xx-advertiser-random-address branch from ef7b81a to 5f464fb Compare January 9, 2025 09:05
@deadprogram
Copy link
Member Author

@ysoldak rebased againstdev.

@deadprogram
Copy link
Member Author

Thanks for review @ysoldak now merging.

@deadprogram deadprogram merged commit 0cdcf6d into dev Jan 9, 2025
4 checks passed
@deadprogram deadprogram deleted the nrf528xx-advertiser-random-address branch January 9, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants