Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf*: use bledebug tag and 'debug' variable instead of modify source #225

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

deadprogram
Copy link
Member

This PR modifies the nrf* implementation to use the bledebug tag and _debug variable instead of modify source to turn on/off debug logging mode.

Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although aesthetically I would have preferred debug instead of _debug.

(That means, feel free to merge as-is).

@deadprogram
Copy link
Member Author

aesthetically I would have preferred debug instead of _debug

I have updated this PR to use debug. Thanks for the feedback on that @aykevl it does look better now.

@deadprogram deadprogram changed the title nrf*: use bledebug tag and '_debug' variable instead of modify source nrf*: use bledebug tag and 'debug' variable instead of modify source Jan 16, 2024
@deadprogram
Copy link
Member Author

Now merging, thanks again @aykevl

@deadprogram deadprogram merged commit 564b0ba into dev Jan 16, 2024
5 checks passed
@deadprogram deadprogram deleted the debug-build-tag branch January 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants