-
-
Notifications
You must be signed in to change notification settings - Fork 255
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use arithmetic bash comparisons (#1776)
As discussed in tiny-pilot/style-guides#19 (comment), and in eager compliance with the [Google bash style guide](https://google.github.io/styleguide/shellguide.html#s6.9-arithmetic), we can replace all instances of `[[ -gt ]]` or `[[ -lt ]]` with arithmetic expressions (`(( > ))` or `(( < ))`). I’ve briefly tested all scripts, so from my side a double-check on the code would be enough as review. <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1776"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a> Co-authored-by: Jan Heuermann <[email protected]>
- Loading branch information
1 parent
aa9bd31
commit 942845f
Showing
4 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters