Skip to content

Commit

Permalink
Disable parallel e2e test execution locally (#1695)
Browse files Browse the repository at this point in the history
Until we have addressed
#1694, I’d suggest to
disable parallel e2e test execution locally, otherwise there can be
erratic failures in Pro (due to the security tests interfering with
other tests).

On my local machine, this changes e2e execution speed from ~20s to ~26s.
On CI, it obviously doesn’t change.
<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1695"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>

Co-authored-by: Jan Heuermann <[email protected]>
  • Loading branch information
jotaen4tinypilot and jotaen authored Nov 30, 2023
1 parent 3d15865 commit 55c4b36
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions playwright.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ export default defineConfig({
/* Fail the build on CI if you accidentally left test.only in the source code. */
forbidOnly: !!process.env.CI,
retries: 0,
/* Opt out of parallel tests on CI. */
workers: process.env.CI ? 1 : undefined,
/* Opt out of parallel tests, until we have fixed our test setup in that
regard. See https://github.com/tiny-pilot/tinypilot/issues/1694 */
workers: 1,
reporter: "html",
use: {
baseURL: process.env.E2E_BASE_URL || "http://0.0.0.0:9000",
Expand Down

0 comments on commit 55c4b36

Please sign in to comment.