Skip to content

Commit

Permalink
Skip installing git in build_bundle CI step (#1564)
Browse files Browse the repository at this point in the history
`create-bundle` [used to depend on
git](https://github.com/tiny-pilot/tinypilot/blob/1.8.0/bundler/create-bundle),
as it downloaded external roles using git and used `git` to pull version
information about the local repo.

We've since simplified the bundle build process, so we no longer require
git, and we can delete the CI step when we install git into the
container. This saves us about 5s on every bundle build in CI.

<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1564"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
  • Loading branch information
mtlynch authored Aug 11, 2023
1 parent ecc15fa commit 330978a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .circleci/continue_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,6 @@ jobs:
- checkout
- attach_workspace:
at: ./bundler/bundle/
- run:
name: Install dependencies
command: sudo apt-get update && sudo apt-get install -y git
- run:
name: Create the bundle
command: ./bundler/create-bundle
Expand Down

0 comments on commit 330978a

Please sign in to comment.