Fix cors match #977
Merged
Fix cors match #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add comments explaining the logic. Thanks! |
or-else
reviewed
Oct 26, 2025
or-else
reviewed
Oct 26, 2025
or-else
reviewed
Oct 26, 2025
|
Also, please consider adding a few examples of supported URLs here: Line 143 in b6b8959 |
added 4 commits
October 26, 2025 20:50
or-else
reviewed
Oct 29, 2025
server/media/media.go
Outdated
|
|
||
| matched := true | ||
| for i, part := range allowedParts { | ||
| if part == "*" && (i == 0 || part == allowedParts[i-1]) { |
There was a problem hiding this comment.
I don't understand the && (i == 0 || part == allowedParts[i-1]). Is it to prevent patterns like abc.*.example.com? Please add a comment with an explanation.
There was a problem hiding this comment.
turns out that this part was actually unnecessary
|
Any update on this? |
added 2 commits
November 4, 2025 14:03
or-else
approved these changes
Nov 4, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow matching cors with wildcards like this
https://*.*.example.com,https://*.example.com