Use HTTP Post when retrieving result #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix inverted boolean logic for has_commands check - Ensure GET is used when no commands are present - Ensure POST is used when commands are present - Add comprehensive tests for both GET and POST scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching the result of a compression, users call the method result(). This will do a request to an url like:
https://api.tinify.com/output/<randomstring>This will resolve to a file.
Because it is possible to add commands to this request such as and other commands, the result would be a
GETrequest with a body. Although this is possible, it is not recommended.Therefor we should change the method to a POST. Shouldn't be a breaking change so patched the version.