Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a workaround for ruby/resolv/issues/23 #834

Conversation

BobSilent
Copy link
Contributor

@BobSilent BobSilent commented Oct 4, 2023

Hi @mburumaxwell,

this PR revives the changes that PR #369 brought with it and unfortunately were lost some time ago.

Can you please add this once again, until Ruby Resolv bug gets merged.

Thanks a lot.

@mburumaxwell
Copy link
Contributor

If I get this correctly, WORKAROUND_CMD will be an ENV variable?
What are some of the values that would be set?

@BobSilent
Copy link
Contributor Author

Please see the details here #369

The issue I have is that within my network environment the docker host itself cannot resolve any network name, therefore some nameservers are configured, but unfortunately due to the bug (ruby/resolv/issues/23) I need to "patch" the /etc/resolv.conf before the image runs.
Currently I create an own docker image which is exactly the same as your images, with just one additional line during startup:
sed -i 1' s/^/#/' /etc/resolv.conf
in order to comment out the first nameserver entry which I am having issues with.

Currently I add an extra env with this value sed -i 1' s/^/#/' /etc/resolv.conf

@mburumaxwell
Copy link
Contributor

Since you are building custom images, have you tried adding that to your Dockerfile with a custom bin/run.sh? For example:

ARG ECOSYSTEM
FROM ghcr.io/tinglesoftware/dependabot-updater-$ECOSYSTEM

WORKDIR ${DEPENDABOT_HOME}
COPY --chown=dependabot:dependabot run.sh bin/run.sh

@BobSilent
Copy link
Contributor Author

That's what I'm doing right now, but to be honest I would really prefer to use your image out-of-the-box, without any modifications from my site. As this has the downside that I frequently have to update and maintain my images, if they do not work with an updated extension.

That's why I really would like to ask you to add this minor and non breaking change again here - even if this is against your code cleanness (which I completely understand). 🙏

I'll continue to get the real fix PR merged @ruby/resolv - but unfortunately there I did not get any response up to now.

@Thulasi225
Copy link

That's why I really would like to ask you to add this minor and non breaking change again here - even if this is against your code cleanness (which I completely understand). 🙏

I'll continue to get the real fix PR merged @ruby/resolv - but unfortunately there I did not get any response up to now.

updater/bin/run.sh Outdated Show resolved Hide resolved
@BobSilent BobSilent force-pushed the workaround-for-ruby-resolv-issue-23 branch from c1e74f7 to 7f7224b Compare May 22, 2024 20:55
@mburumaxwell mburumaxwell merged commit 21fefc9 into tinglesoftware:main May 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants