-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds custom dependabot file location support #575
adds custom dependabot file location support #575
Conversation
@DaleMckeown thanks for your contribution. However, locking the configuration file path to be under the .github folder happened some months ago because the loading of the dependabot-azure-devops/updater/bin/update-script.rb Lines 458 to 468 in b179ed6
If you can get that changed then we can merge this. Even then, maybe we end up fixing to |
@mburumaxwell Thanks, I wasn't aware of the upstream requirement. I'll see what I can do. |
Looks like We could theoretically implement our own config file loader class that implements I've never written ruby, but happy to give it a go and see what happens. @mburumaxwell thoughts on this approach? |
@mburumaxwell I've had a go at this! I can't run the project so it's not tested, I may have missed some bits. |
Thanks for giving it a shot. It does seem like the easiest way to get things to work.
All in all, kudos for the courage. |
@mburumaxwell I think I've reached the limit of my skillset with this, my lack of knowledge in Ruby is hampering my ability to add the unit tests as requested. Feel free to abandon this if no one can finish polishing it. |
Sorry, this is exactly what happens when the community asks for a feature. Asking is the easy part, implementing is always the hard part, especially when one has to add tests too. I can't promise to get on this soon. Hopefully, someone else in need of the same can get it done. I am certain that there are workarounds for this. |
@DaleMckeown , as per #884 and #885, we no longer parse the dependabot.yml file in the Ruby script but instead pass the necessary details via ENV. This means we can read a file from anywhere. Could you relook into this now? You'd only need to make changes in the extension and server components. |
Should resolve #574