Skip to content

Commit

Permalink
No need for MakeResourceName(...)
Browse files Browse the repository at this point in the history
  • Loading branch information
mburumaxwell committed Sep 26, 2023
1 parent 2509ad6 commit 6b3a89f
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions server/Tingle.Dependabot/Workflow/UpdateRunner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public UpdateRunner(IFeatureManagerSnapshot featureManager, IOptions<WorkflowOpt

public async Task CreateAsync(Project project, Repository repository, RepositoryUpdate update, UpdateJob job, CancellationToken cancellationToken = default)
{
var resourceName = MakeResourceName(job);
var resourceName = job.Id;

// if we have an existing one, there is nothing more to do
var containerAppJobs = resourceGroup.GetContainerAppJobs();
Expand Down Expand Up @@ -136,7 +136,7 @@ public async Task CreateAsync(Project project, Repository repository, Repository

public async Task DeleteAsync(UpdateJob job, CancellationToken cancellationToken = default)
{
var resourceName = MakeResourceName(job);
var resourceName = job.Id;

try
{
Expand All @@ -153,7 +153,7 @@ public async Task DeleteAsync(UpdateJob job, CancellationToken cancellationToken

public async Task<UpdateRunnerState?> GetStateAsync(UpdateJob job, CancellationToken cancellationToken = default)
{
var resourceName = MakeResourceName(job);
var resourceName = job.Id;

try
{
Expand Down Expand Up @@ -205,7 +205,7 @@ public async Task DeleteAsync(UpdateJob job, CancellationToken cancellationToken
public async Task<string?> GetLogsAsync(UpdateJob job, CancellationToken cancellationToken = default)
{
var logs = (string?)null;
var resourceName = MakeResourceName(job);
var resourceName = job.Id;

// pull logs from Log Analaytics
if (string.IsNullOrWhiteSpace(logs))
Expand All @@ -222,8 +222,6 @@ public async Task DeleteAsync(UpdateJob job, CancellationToken cancellationToken
return logs;
}

internal static string MakeResourceName(UpdateJob job) => $"dependabot-{job.Id}";

internal async Task<IDictionary<string, string>> CreateEnvironmentVariables(Project project,
Repository repository,
RepositoryUpdate update,
Expand Down

0 comments on commit 6b3a89f

Please sign in to comment.