Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core rework #7

Merged
merged 34 commits into from
Jan 22, 2024
Merged

Core rework #7

merged 34 commits into from
Jan 22, 2024

Conversation

tingerrr
Copy link
Owner

@tingerrr tingerrr commented Jan 18, 2024

This PR reworks the core implementation and comes various improvements.

User facing improvements

  • distinguishing of soft and hard errors for the command line
  • improved and more consistent error messages
  • more consistent test result reporting
  • additional hints for some messages
  • correct implementation of --fail-fast
  • support for no optimization updates

Internal improvements

  • proper separation of test running and result reporting
  • less file system checks
  • unification of project and file system access

Closes #6.

@tingerrr
Copy link
Owner Author

I'm still unsure how I best remove the usages of Reporter in functions of Project, ideally it doesn't need any synchronization because only reporting should be decoupled from the actual operation similar to testing.

@tingerrr
Copy link
Owner Author

tingerrr commented Jan 19, 2024

Things that are not planned for this PR, but I want to note down regardless, as they have become easier to accomplish following this rework:

  • improve logging
    • writing logs to log file
    • maybe only display spans on trace level
  • make rayon thread pool configurable from the CLI
  • handle open crate edge cases
  • user configuration
  • configure project wide things with convenient setup with typst-manifest using toml_edit

As for now, any further commits should only fix inconsistencies and bugs, I consider the rework finished and this branch ready for testing.

@tingerrr tingerrr force-pushed the core-rework branch 2 times, most recently from 5f4c053 to fa8b57c Compare January 20, 2024 00:14
@tingerrr tingerrr marked this pull request as ready for review January 22, 2024 13:25
@tingerrr
Copy link
Owner Author

I've done various tests locally and in CI over at hydra (don't mind the chaos of commits, CI is hard) and I'm confident that this PR is ready.

@tingerrr tingerrr merged commit 39d9efe into main Jan 22, 2024
@tingerrr tingerrr deleted the core-rework branch January 22, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework and cleanup core implementation
1 participant