Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter candidates defined after the current page #21

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

freundTech
Copy link
Contributor

Previously when both prev and last candidates were none hydra would show candidates defined on later pages. I believe that candidates defined on pages after the current page should never be displayed.

@freundTech
Copy link
Contributor Author

Or should this be configurable?
I personally can't think of any option why one would want to display a heading defined on a later page.
You basically already signed off on this in #19 (comment), but through the restructuring of that PR it was changed to only affect last candidates, which I think was a mistake.

Previously when both prev and last candidates were none hydra would show
candidates defined on later pages. I believe that candidates defined on
pages after the current page should never be displayed.
@freundTech freundTech changed the title Filter candidates defined after the the current page Filter candidates defined after the current page Jul 10, 2024
@freundTech
Copy link
Contributor Author

Force pushed to fix typo in commit message.

@tingerrr
Copy link
Owner

tingerrr commented Jul 11, 2024

Unfortunate that it slipped through my review, thank you! Could you update the changelog to reflect that fix with a link to the PR (i.e. #21)?

That would go under a new ## Fixed section.

@freundTech
Copy link
Contributor Author

Done!

@tingerrr
Copy link
Owner

Thank you!

@tingerrr tingerrr merged commit b33fb6d into tingerrr:main Jul 11, 2024
1 check passed
@freundTech freundTech deleted the filter-future-candidates branch July 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants