💄 Docs NavBar consistency and docs UI rework #2175
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshbermanssw
changed the title
|
Doesn't overlap quite right with the cookies pop-up. Should be underneath.
|
|
The close menu button is also obscuring some content, and that content should be removed as well on smaller screens (it's covered by the new menu you've put in). |
|
Legendary PBI. Looks really nice. |
|
Nitpicky, but the highlight is starting to escape.
|
|
A couple more changes we could make to improve this. These came from the daily and could be a new PBI if you'd rather divide up the work. Update the search to match the new ToC? Create an alternative to the default dropdown menu. |
|
Another niche one – the tables don't really match the changed background. One for a PBI or the tribute imo (or my solution for now would be to add a little border).
|
@isaaclombardssw - quicker solution would be to give the white/grey rows lower opacity so it gets a tint of the blue background (I wasn't here 👀) |
|
Figure: Modernized version selector |
|
Looks dope, just one more little styling issue to fix.
|
| position: fixed; | ||
| z-index: 250; | ||
| left: 0; | ||
| z-index: 49; |
There was a problem hiding this comment.
Should we be marking the major styling issues for that epic we're planning?
ex. TODO – z-indices should be within tailwind standard values, note that some existing z-values go into the 10's of thousands.
| background-image: | ||
| linear-gradient(rgba(255, 255, 255, 0.5), rgba(255, 255, 255, 0.5)), | ||
| url("data:image/svg+xml,%3Csvg preserveAspectRatio='none' viewBox='0 0 194 109' fill='none' xmlns='http://www.w3.org/2000/svg'%3E%3Cg clip-path='url(%23clip0_566_318)'%3E%3Crect width='194' height='109' fill='white' /%3E%3Cmask id='mask0_566_318' style='mask-type:alpha' maskUnits='userSpaceOnUse' x='0' y='0' width='194' height='109'%3E%3Crect width='194' height='109' fill='url(%23paint0_linear_566_318)' /%3E%3C/mask%3E%3Cg mask='url(%23mask0_566_318)'%3E%3Crect width='194' height='109' fill='url(%23paint1_linear_566_318)' /%3E%3C/g%3E%3C/g%3E%3Cdefs%3E%3ClinearGradient id='paint0_linear_566_318' x1='97' y1='0' x2='97' y2='109' gradientUnits='userSpaceOnUse'%3E%3Cstop stop-color='%23D9D9D9' stop-opacity='0.45' /%3E%3Cstop offset='0.229052' stop-color='%23D9D9D9' stop-opacity='0.1678' /%3E%3Cstop offset='0.677779' stop-color='%23D9D9D9' stop-opacity='0.0513' /%3E%3Cstop offset='1' stop-color='%23D9D9D9' stop-opacity='0' /%3E%3C/linearGradient%3E%3ClinearGradient id='paint1_linear_566_318' x1='0' y1='54.5' x2='194' y2='54.5' gradientUnits='userSpaceOnUse'%3E%3Cstop stop-color='%2353E9DD' /%3E%3Cstop offset='0.34375' stop-color='%2368D7E4' /%3E%3Cstop offset='0.59375' stop-color='%2359BFF2' /%3E%3Cstop offset='1' stop-color='%234BA8FF' /%3E%3C/linearGradient%3E%3CclipPath id='clip0_566_318'%3E%3Crect width='194' height='109' fill='white' /%3E%3C/clipPath%3E%3C/defs%3E%3C/svg%3E "); |
There was a problem hiding this comment.
TODO mark for this one as well I reckon
As per #2157
We wanted to make the navbar consistent across tina.io site. To do so we have replaced the old navigation bar on Tina docs with the new one used elsewhere on the site
test passed by jeoffrey and @bettybondoc
Changes
<NavBar/>component so that we dont use sticky on the /docs (and sticky prop to<Layout><Layout/>into the<DocumentNavigation/>componentFigure: New navbar on /docs