Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nonstationary #118

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update nonstationary #118

wants to merge 4 commits into from

Conversation

timsainb
Copy link
Owner

@timsainb timsainb commented Nov 9, 2024

Updates nonstationary version of algorithm to be more uniform with stationary version, by using moving mean + std to do noise thresholding.

This will create a small breaking change for current pipelines, since the parameters for the nonstationry have now switched.
mainly, n_std_thresh_stationary is now n_std_thresh, and shared across stationary and nonstationary.

@timsainb timsainb requested a review from nuniz November 9, 2024 11:37
@nuniz
Copy link
Collaborator

nuniz commented Nov 9, 2024

Hi Tim
If we're planning non-backwards compatible changes, we should also think about other updates for version 4, like adding the TensorFlow implementation or a refactor I've been thinking about.

How about we create a branch for version 4 and discuss this later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants