Feature detection suggestion #141
Conversation
Try to avoid infinite loop on iOS if something happened with draggable dom object
I have made some research about android webkit and iOS safari. Caniuse not right about Chrome android, he have support of native DnD from M54 version. And i have check iOS 11-12 and 9-10, so made regexp for detection iOS version and android chrome version.
|
Thanks for your effort. How did you test the changes you made? On which devices and browser/OS combinations did you conduct testing? I'm hesitant to make changes to this part of the polyfill as long as it's working for everyone, so as long as no bug reports keep flying in I'd rather not change this. Having automated browser tests is still an open task that was started but not yet finished and would be a precondition because otherwise we have to rely on having lots of device/browser/OS combinations for manual testing.
The desktop browser are part of the feature detection because of hybrid/tablet devices which are running browsers that are not fully able to handle HTML5 drag and drop. Therefore those should stay part of the feature detection until proven otherwise. Also I recognized the changes of your other PR are part of this PR. Mixing PRs is not a good idea. Your other PR lacks substantial information on why you introduced the changes which is why it's not been reviewed. |
|
I have tested Android virtual machines from 4.4 to 8, and real device with 8. From 8, DnD definitely support out of the box, and on early devices if they updated WebKit from Google play. For now your polyfill say what my phone doesn't have support of DnD but it's wrong (Android 8.1 and fresh WebKit) For iOS I have checked on 9 and 12 on real device and 8 10 11 in simulator. Your polyfill say again what it doesn't support, but it's supported from iOS 11. So what's why I have made this changes by browser user agent. |
I have made some research about android webkit and iOS safari. Caniuse
not right about Chrome android, he have support of native DnD from M54
version. And I check the iOS 11-12 and 9-10, so made regexpr for
detection iOS version and android chrome.
About desktop browsers, i'm not sure why we should use polyfill. At least IE, Edge, Chrome, Safari have native support of DnD, so I have disable blink detection and other stuff for desktop.