Skip to content

Fixed Adapter._decode typehints #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed Adapter._decode typehints #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion construct-stubs/core.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class Adapter(
self, subcon: Construct[SubconParsedType, SubconBuildTypes]
) -> None: ...
def _decode(
self, obj: SubconBuildTypes, context: Context, path: PathType
self, obj: SubconParsedTypes, context: Context, path: PathType
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no variable called SubconParsedTypes (with an 's' at the end). There is only SubconParsedType.

But if you use SubconParsedType then pyright (1.1.391) generates an error:
image

) -> ParsedType: ...
def _encode(
self, obj: BuildTypes, context: Context, path: PathType
Expand Down