Add bulk read temperature method#120
Open
SimonInOps wants to merge 1 commit intotimofurrer:masterfrom
Open
Conversation
Owner
|
@SimonInOps this is nice work! I'll need some time to review it. I also don't have sensors handy to actually give this a try. If anyone wants to double check on their system feel free to do so and leave a comment :) Pinging you because you've showed interest in #115: @CJKohler @then3rd @h-wissing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've created a synchronous method to implement bulk read temperature operation.
It increases efficiency to get all sensors' temperature in time of a longest single sensor cycle.
Tested with 5 sensors with a 12bit resolution, I've reduced the time from:
4.016239susing traditionalget_temperature()with a for loop,to
0.897658susing bulk read capability.Let me know if I'm missing something.
Solves: #115