Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getpass module to get the user #101

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

dwardu89
Copy link
Contributor

@dwardu89 dwardu89 commented Apr 7, 2024

Using the getpass module instead which is an OS Agnostic approach to getting the running user.

https://docs.python.org/3/library/getpass.html

Copy link
Owner

@timmo001 timmo001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work pretty well 👍 Cross platform too

@timmo001 timmo001 merged commit 446a27f into timmo001:master Apr 7, 2024
12 of 14 checks passed
@timmo001
Copy link
Owner

timmo001 commented Apr 7, 2024

Ruff being strange, its fine locally. I'll fix this after

@timmo001
Copy link
Owner

timmo001 commented Apr 7, 2024

Fixes timmo001/system-bridge#2994

@timmo001 timmo001 added the bugfix label Apr 7, 2024
@florian-asche
Copy link

If you push a new system-bridge deb package i can test it here to verify the fix works.

@florian-asche
Copy link

Ruff looks like temp issue with the github api to me. Maybe a retry will fix it. And the lint check can be fixed with fix parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants