-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Dropdown Options #897
Conversation
@pratikkabade is attempting to deploy a commit to the timlrx's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@timlrx any problem with pr? |
@pratikkabade the build failed. Could you run it through prettier and push the updated changes? |
I thought it failed because of permission youve set, sure I'll give it a try |
@timlrx I've made |
@timlrx any problem with PR? |
@pratikkabade, the desktop version in good. The mobile version needs to be updated. I was thinking either to list it out but indent it like Dribble or making it an expandable dropdown like Figma. Any preference? |
@@ -6,4 +6,12 @@ const headerNavLinks = [ | |||
{ href: '/about', title: 'About' }, | |||
] | |||
|
|||
export const headerNavOptions = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for an additional field. You can modify the original headerNavLink to something like this:
const headerNavLinks = [
{ href: '/', title: 'Home' },
{ href: '/blog', title: 'Blog' },
{ href: '/tags', title: 'Tags' },
{ title: 'Others': children: [
{ href: '/projects', title: 'Projects' },
{ href: '/about', title: 'About' },
]
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it I'll see if i could do that and will change
@@ -37,6 +38,7 @@ const Header = () => { | |||
{link.title} | |||
</Link> | |||
))} | |||
<NavOptions /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can move the rendering of all the headerNavLinks
to NavOptions
Enhancement
Fixes #867
Implemented dropdown options in the navbar to allow users to hide additional options
Visuals