This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add struct tags to dataset config objects #1807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhudson
force-pushed
the
nhudson/add_struct_tags
branch
2 times, most recently
from
a26f1f2
to
20f330f
Compare
alejandrodnm
approved these changes
Dec 21, 2022
nhudson
force-pushed
the
nhudson/add_struct_tags
branch
from
1d4ebf0
to
0477a9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the struct tags around the
dataset.Config{}struct so we can use this as an external config validator. Without this you will get the following error when trying to Unmarshal data into the struct.Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: