Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Adds support for rollup query helper based on query range inputs #1780

Open
wants to merge 7 commits into
base: feature_metric_rollup
Choose a base branch
from
Open

Adds support for rollup query helper based on query range inputs #1780

wants to merge 7 commits into from

Commits on Nov 2, 2022

  1. Adds support to create/delete metric rollups via dataset-config. 

    Signed-off-by: Harkishen-Singh <[email protected]>

This commit adds support for creation or deletion of metric rollups by reading
the dataset-config file. The dataset config file contains a new field `downsample:`
which supports 2 options: `automatic` & `resolution`.

If `automatic` is false, then
connector updates in the database so that `_prom_catalog.scan_for_new_rollups` does not
create any new rollups (Caggs).

`resolution` is a comma separated list of resolutions for downsampling, in a way that
label:resolution:retention is the format that is needed.
Example: `short:5m:90d,long:1h:365d`
-> The resolution works in a strict manner. Its aim is to make sure that the database contains
exactly those resolutions that are mentioned in the dataset config. Like, if the database
already contains `short` and `long` downsampled data and the dataset is supplied with `short:5m:90d,very_long:1d:365d`
then `long` downsampled case is deleted and `very_long` is created.
-> `resolution` is applied if `automatic` is `true`. If automatic is not given in dataset config, it defaults to `true`
based on our plan to keep downsampling applied as a default setting.
    @Harkishen-Singh
    Harkishen-Singh committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    e1d967f View commit details
    Browse the repository at this point in the history

  2. Update resolution config and add E2E tests for creation/deletion of r… 

    …ollups.

Signed-off-by: Harkishen-Singh <[email protected]>
    @Harkishen-Singh
    Harkishen-Singh committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    8d1dbbc View commit details
    Browse the repository at this point in the history

  3. Refactor DayDuration -> day.Duation 

    Signed-off-by: Harkishen-Singh <[email protected]>
    @Harkishen-Singh
    Harkishen-Singh committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    782dad8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Update tests related to register_metric_view(). 

    Signed-off-by: Harkishen-Singh <[email protected]>
    @Harkishen-Singh
    Harkishen-Singh committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5409511 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Adds support to instrument metric-rollups behaviour 

    Signed-off-by: Harkishen-Singh <[email protected]>
    @Harkishen-Singh
    Harkishen-Singh committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    8281a59 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Update rollups creation/deletion/updation using dataset-config. 

    Signed-off-by: Harkishen-Singh <[email protected]>
    @Harkishen-Singh
    Harkishen-Singh committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ec7c1d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Implement rollup resolution decider for incoming queries. 

    Signed-off-by: Harkishen-Singh <[email protected]>
    @Harkishen-Singh
    Harkishen-Singh committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    9e1f5c5 View commit details
    Browse the repository at this point in the history