This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix mxid bloat #1676
Draft
Fix mxid bloat #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevian
force-pushed
the
mxid_fix
branch
2 times, most recently
from
b8d82f1
to
34d5e87
Compare
ON CONFLICT clauses can cause row locks, which uses multitransact mxids. Therefore, avoid using long transactions with ON CONFLICT. This patch forces all inserts with ON CONFLICT to commit metrics in separate transactions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ON CONFLICT clauses can cause row locks, which uses multitransact mxids. Therefore, avoid using long transactions with ON CONFLICT.
This patch forces all inserts with ON CONFLICT to commit metrics in separate transactions.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: