Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Commit

Permalink
Add support for PG15
Browse files Browse the repository at this point in the history
  • Loading branch information
alejandrodnm committed Jan 9, 2023
1 parent b3c030d commit 85c784e
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/go-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
docker_image_12: ${{ steps.metadata.outputs.docker_image_12 }}
docker_image_13: ${{ steps.metadata.outputs.docker_image_13 }}
docker_image_14: ${{ steps.metadata.outputs.docker_image_14 }}
docker_image_15: ${{ steps.metadata.outputs.docker_image_15 }}
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v3
Expand All @@ -55,6 +56,7 @@ jobs:
docker_image_12=$(echo ${{inputs.docker_image_prefix}}-pg12)
docker_image_13=$(echo ${{inputs.docker_image_prefix}}-pg13)
docker_image_14=$(echo ${{inputs.docker_image_prefix}}-pg14)
docker_image_15=$(echo ${{inputs.docker_image_prefix}}-pg15)
else
branch_name=$(echo ${{github.head_ref || github.ref_name}} | sed 's#/#-#')
possible_branch_tag=$(echo ${branch_name}-ts2)
Expand All @@ -64,10 +66,12 @@ jobs:
docker_image_12=$(./scripts/fallback-docker.sh ${image_base}:${possible_branch_tag}-pg12 ${image_base}:${stable_branch_tag}-pg12)
docker_image_13=$(./scripts/fallback-docker.sh ${image_base}:${possible_branch_tag}-pg13 ${image_base}:${stable_branch_tag}-pg13)
docker_image_14=$(./scripts/fallback-docker.sh ${image_base}:${possible_branch_tag}-pg14 ${image_base}:${stable_branch_tag}-pg14)
docker_image_15=$(./scripts/fallback-docker.sh ${image_base}:${possible_branch_tag}-pg15 ${image_base}:${stable_branch_tag}-pg15)
fi;
echo "docker_image_12=${docker_image_12}" >> ${GITHUB_OUTPUT}
echo "docker_image_13=${docker_image_13}" >> ${GITHUB_OUTPUT}
echo "docker_image_14=${docker_image_14}" >> ${GITHUB_OUTPUT}
echo "docker_image_15=${docker_image_15}" >> ${GITHUB_OUTPUT}
test-end-to-end:
name: e2e
Expand All @@ -76,6 +80,7 @@ jobs:
strategy:
matrix:
test-setups:
- {name: "Singlenode (15)", shortname: "singlenode-15", multi: false, pg: 15}
- {name: "Singlenode (14)", shortname: "singlenode-14", multi: false, pg: 14}
- {name: "Singlenode (13)", shortname: "singlenode-13", multi: false, pg: 13}
- {name: "Singlenode (12)", shortname: "singlenode-12", multi: false, pg: 12}
Expand Down Expand Up @@ -126,6 +131,7 @@ jobs:
strategy:
matrix:
test-setups:
- {name: "Singlenode (15)", shortname: "singlenode-15", multi: false, pg: 15}
- {name: "Singlenode (14)", shortname: "singlenode-14", multi: false, pg: 14}
- {name: "Singlenode (13)", shortname: "singlenode-13", multi: false, pg: 13}
- {name: "Singlenode (12)", shortname: "singlenode-12", multi: false, pg: 12}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
strategy:
matrix:
pg:
- 15
- 14
- 13
# TODO (mat): re-enable the pg12 test
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ We use the following categories for changes:
## Unreleased

### Added
- Add support for PostgreSQL 15
- Alerts from promscale monitoring mixin are groupped also by namespace label [#1714]
- Added a new family of metrics tracking database maintenance jobs durations and failures [#1745]
- Allow config options in file to be set as yaml mappings [#1737]
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ pkg/tests/testdata/traces-dataset.sz:
wget https://github.com/timescale/promscale-test-data/raw/main/traces-dataset.sz -O ./pkg/tests/testdata/traces-dataset.sz

.PHONY: e2e
e2e: DOCKER_IMAGE?=$(shell ./scripts/fallback-docker.sh $(LOCAL_DOCKER_BASE):head-ts2-pg14 $(GHCR_DOCKER_BASE):$(CURRENT_BRANCH)-ts2-pg14 $(GHCR_DOCKER_BASE):$(EXTENSION_VERSION)-ts2-pg14)
e2e: DOCKER_IMAGE?=$(shell ./scripts/fallback-docker.sh $(LOCAL_DOCKER_BASE):head-ts2-pg15 $(GHCR_DOCKER_BASE):$(CURRENT_BRANCH)-ts2-pg15 $(GHCR_DOCKER_BASE):$(EXTENSION_VERSION)-ts2-pg15)
e2e: pkg/tests/testdata/traces-dataset.sz generate
go test -v ./pkg/tests/end_to_end_tests/ -timescale-docker-image=$(DOCKER_IMAGE)
# TODO: Skipping multinode because tests are broken for now
# go test -v ./pkg/tests/end_to_end_tests/ -use-multinode -timescale-docker-image=$(DOCKER_IMAGE)

.PHONY: jaeger-storage-test
jaeger-storage-test: DOCKER_IMAGE?=$(shell ./scripts/fallback-docker.sh $(LOCAL_DOCKER_BASE):head-ts2-pg14 $(GHCR_DOCKER_BASE):$(CURRENT_BRANCH)-ts2-pg14 $(GHCR_DOCKER_BASE):$(EXTENSION_VERSION)-ts2-pg14)
jaeger-storage-test: DOCKER_IMAGE?=$(shell ./scripts/fallback-docker.sh $(LOCAL_DOCKER_BASE):head-ts2-pg15 $(GHCR_DOCKER_BASE):$(CURRENT_BRANCH)-ts2-pg15 $(GHCR_DOCKER_BASE):$(EXTENSION_VERSION)-ts2-pg15)
jaeger-storage-test:
go test -v ./pkg/tests/end_to_end_tests/ -timescale-docker-image=$(DOCKER_IMAGE) -tags=jaeger_storage_test -run="^TestJaegerStorageIntegration/"

Expand Down
1 change: 1 addition & 0 deletions docker-compose/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: '3.0'

services:
db:
# TODO change to 15 when the new HA image is available
image: timescale/timescaledb-ha:pg14-latest
ports:
- 5432:5432/tcp
Expand Down
1 change: 1 addition & 0 deletions docker-compose/high-availability/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: '3.0'

services:
db:
# TODO change to 15 when the new HA image is available
image: timescale/timescaledb-ha:pg14-latest
ports:
- 5432:5432/tcp
Expand Down
1 change: 1 addition & 0 deletions docker-compose/jaeger-promscale-demo/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: '3.0'

services:
db:
# TODO change to 15 when the new HA image is available
image: timescale/timescaledb-ha:pg14-latest
environment:
POSTGRES_PASSWORD: password
Expand Down
3 changes: 2 additions & 1 deletion docker-compose/promscale-demo/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: '3.0'

services:
timescaledb:
# TODO change to 15 when the new HA image is available
image: timescale/timescaledb-ha:pg14-latest
restart: on-failure
ports:
Expand Down Expand Up @@ -121,7 +122,7 @@ services:
- 5052:5000/tcp
environment:
- OTEL_EXPORTER_OTLP_ENDPOINT=collector:4317

digit:
image: timescale/promscale-demo-digit
restart: on-failure
Expand Down
2 changes: 1 addition & 1 deletion pkg/version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var (
Branch = "" // Comes from -ldflags settings
EarliestUpgradeTestVersion = "0.3.0" // 0.3.0 earliest version an image with correct extension versions exists

PgVersionNumRange = ">=12.x <15.x" // Corresponds to range within pg 12.0 to pg 14.99
PgVersionNumRange = ">=12.x <16.x" // Corresponds to range within pg 12.0 to pg 14.99

This comment has been minimized.

Copy link
@tnn2

tnn2 Jan 11, 2023

the comment should be updated as well

pgAcceptedVersionsRange = semver.MustParseRange(PgVersionNumRange)

TimescaleVersionRangeString = ">=2.6.1 <2.99.0"
Expand Down

0 comments on commit 85c784e

Please sign in to comment.