Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Http Request Duration Histogram should be in seconds unit #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zslow
Copy link

@Zslow Zslow commented Feb 20, 2020

Hi,
I changed the units of the Http Request Duration Histogram to Seconds.
Here's a link to the official Prometheus documentation where states that base units should be used for any metric, as a best practice.

https://prometheus.io/docs/practices/naming/#metric-names

We are testing this adapter on a project and needed the metric with the right unit in order to know if http requests are being lost.

Thank You.

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   13.18%   13.18%           
=======================================
  Files           4        4           
  Lines         622      622           
=======================================
  Hits           82       82           
  Misses        525      525           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6d240...2c2f8fd. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants