Add support for nested complex types (#60) #61
Conversation
kavhad
changed the title
kavhad
changed the title
There was a problem hiding this comment.
Thanks for your contribution, much appreciated.
Some minor comments on whitespace that need sorting out, and I haven't read the diff on the Metahandler yet as it's full of diff noise, but so far looking great.
I've set up Appveyor now to run the unit tests so keep an eye on that when you push an update.
If I go quiet feel free to send me reminders, through github or on [email protected]
👍 good work!
Also remind me to actually update the nuget package when we're done.
| @@ -1,111 +1,117 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
why's the whole file changed? line-endings or something?
| @@ -0,0 +1,12 @@ | |||
| using System.ComponentModel.DataAnnotations.Schema; | |||
There was a problem hiding this comment.
It was between a candy bag or perhaps an engine with parts, but candy won :)
| @@ -64,6 +65,8 @@ public void ExampleOfGeneratingSql() | |||
| public class MyDbContext : DbContext | |||
| { | |||
| public DbSet<Foo> Foos { get; set; } | |||
|
|
|||
| @@ -74,8 +77,25 @@ public class Foo | |||
| public int Id { get; set; } | |||
| public Size Size { get; set; } | |||
| public Shape Shape { get; set; } | |||
|
|
|||
| public Bar Bar { get; set; } | |||
There was a problem hiding this comment.
indentation mismatch?
check out the editorconfig in the root folder
| } | ||
|
|
||
| [ComplexType] |
| @@ -1,267 +1,318 @@ | |||
| namespace EfEnumToLookup.LookupGenerator | |||
| { | |||
There was a problem hiding this comment.
large amount of diff-noise here probably due to indent / line-ending differences, fix that up and I'll have another look
|
Ok, I'll try and fix the commented issues. I'm not sure why certain indentations looks different on github diff tool as it looks correct when I do a diff in Visual Studio. |
I've made a fix for the missing use case of when there exists enum within nested complex properties (described in issue #60).