Skip to content

fix: temporary cast to fix OpenAPISpecPathItem #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petewins wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: temporary cast to fix OpenAPISpecPathItem #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1af830e
feat: cast types
petewins Nov 17, 2025
2dcd567
docs: add reference link
petewins Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/OpenApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type {
OpenAPISpec,
OpenAPISpecMethodName,
OpenAPISpecParameter,
OpenAPISpecPathItem,
} from "@effect/platform/OpenApi"
import * as Effect from "effect/Effect"
Expand Down Expand Up @@ -128,10 +129,22 @@ export const make = Effect.gen(function* () {
paramsOptional: true,
}
const schemaId = identifier(operation.operationId ?? path)
const validParameters =
operation.parameters?.filter(
(_) => _.in !== "path" && _.in !== "cookie",
) ?? []

// Merge path-level parameters with operation-level parameters
// Path-level parameters are part of OpenAPI 3.0 spec but not typed in @effect/platform
// This is needed until https://github.com/Effect-TS/effect/issues/5760 is resolved
const pathParameters =
(
methods as OpenAPISpecParameter & {
parameters?: Array<OpenAPISpecParameter>
}
).parameters ?? []
const operationParameters = operation.parameters ?? []
const allParameters = [...pathParameters, ...operationParameters]
const validParameters = allParameters.filter(
(_) => _.in !== "path" && _.in !== "cookie",
)

if (validParameters.length > 0) {
const schema: JsonSchema.Object = {
type: "object",
Expand Down