-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flake.nix #3
base: trunk
Are you sure you want to change the base?
Conversation
Thanks for the submission. I am not familiar with nix packaging, so I have a couple questions:
|
So all the deps are provided by nixpkgs, which is itself pinned by the Yeah, the flake.nix should usually be put at the top-level. Good point about gnu-sed, I'm adding it. Though I'll be unable to test on MacOS Re. a starting point, I think https://zero-to-nix.com/concepts/flakes is nice. Since https://github.com/martinvonz/jj is also packaged with a Also, once your project is packaged with a flake, CI/CD comes for free with for instance https://garnix.io/ (with no need for extra config files) |
There is a work‐in‐progress Nixpkgs PR for |
I am not very familiar with Nix packaging, so... |
@tim-janik Hi! So it's mostly a matter of update frequency. The flake here will always package the latest commit of jj-fzf's main branch, while the one in nixpkgs may only pick up the most stable versions. But it's really your call. |
This adds a flake.nix file so
jj-fzf
can be installed with its deps with Nix, just likejj
.It uses jj v0.23.0 from nixpkgs.