Skip to content

Commit

Permalink
refactor(exporter-trace-otlp-http): fix eslint warnings
Browse files Browse the repository at this point in the history
```
/home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/index.ts
  20:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax

/home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/browser/index.ts
  20:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax

/home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/index.ts
  20:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax

/home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/exporter-trace-otlp-http/src/platform/node/index.ts
  20:1  warning  Using 'ExportAllDeclaration' is not allowed  no-restricted-syntax
```

The comment say we should do this before the next "major" (minor
since we are pre-1.0?) version, which means this is the right time
to do it.

However, I'm not sure if there is a real need/reason for that. As
far as I can tell, this is still exporting exactly the same items
and shouldn't cause any breakages?

Ref open-telemetry#5365
  • Loading branch information
chancancode committed Jan 30, 2025
1 parent 3c040c4 commit 5f7dcdc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 16 deletions.
5 changes: 1 addition & 4 deletions experimental/packages/exporter-trace-otlp-http/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
* limitations under the License.
*/

/* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] --
* TODO: Replace wildcard export with named exports before next major version
*/
export * from './platform';
export { OTLPTraceExporter } from './platform';
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
* limitations under the License.
*/

/* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] --
* TODO: Replace wildcard export with named exports before next major version
*/
export * from './OTLPTraceExporter';
export { OTLPTraceExporter } from './OTLPTraceExporter';
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
* limitations under the License.
*/

/* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] --
* TODO: Replace wildcard export with named exports before next major version
*/
export * from './node';
export { OTLPTraceExporter } from './node';
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@
* limitations under the License.
*/

/* eslint no-restricted-syntax: ["warn", "ExportAllDeclaration"] --
* TODO: Replace wildcard export with named exports before next major version
*/
export * from './OTLPTraceExporter';
export { OTLPTraceExporter } from './OTLPTraceExporter';

0 comments on commit 5f7dcdc

Please sign in to comment.