Skip to content

tests: fix TestTSOKeyspaceGroupSplitElection#10032

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
liupan1111:wip-fix-9842
Dec 11, 2025
Merged

tests: fix TestTSOKeyspaceGroupSplitElection#10032
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
liupan1111:wip-fix-9842

Conversation

@liupan1111
Copy link
Copy Markdown
Contributor

@liupan1111 liupan1111 commented Dec 9, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #9842

What is changed and how does it work?

  • pause split finish, and ensure two keyspace groups primary in the same tso server.

Check List

Tests

  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 9, 2025

Hi @liupan1111. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 9, 2025
liyishuai
liyishuai reviewed Dec 9, 2025
View reviewed changes
Comment thread pkg/keyspace/tso_keyspace_group.go
@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 9, 2025

/retest

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 9, 2025

@liupan1111: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ystaticy
ystaticy reviewed Dec 10, 2025
View reviewed changes
Comment thread tests/integrations/mcs/tso/keyspace_group_manager_test.go Outdated
rleungx
rleungx reviewed Dec 10, 2025
View reviewed changes
Comment thread pkg/keyspace/tso_keyspace_group.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.27%. Comparing base (06ae8ba) to head (a6fa5f2).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10032      +/-   ##
==========================================
- Coverage   78.44%   78.27%   -0.18%     
==========================================
  Files         503      511       +8     
  Lines       67176    68324    +1148     
==========================================
+ Hits        52699    53479     +780     
- Misses      10653    10946     +293     
- Partials     3824     3899      +75
Flag Coverage Δ
unittests 78.27% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rleungx
rleungx reviewed Dec 10, 2025
View reviewed changes
Comment thread tests/integrations/mcs/tso/keyspace_group_manager_test.go Outdated
rleungx
rleungx approved these changes Dec 10, 2025
View reviewed changes
Comment thread pkg/keyspace/tso_keyspace_group.go Outdated
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 10, 2025
@rleungx rleungx changed the title fix the flaky testcase: TestTSOKeyspaceGroupSplitElection tests: fix TestTSOKeyspaceGroupSplitElection Dec 10, 2025
@rleungx
Copy link
Copy Markdown
Member

rleungx commented Dec 10, 2025

As for the PR title, usually we use the subsystem name or module name, see https://github.com/tikv/pd/blob/master/CONTRIBUTING.md

@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 10, 2025

As for the PR title, usually we use the subsystem name or module name, see https://github.com/tikv/pd/blob/master/CONTRIBUTING.md

ok, let me modify

@liupan1111
tests: fix the flaky testcase: TestTSOKeyspaceGroupSplitElection
a6fa5f2 
Signed-off-by: Pan Liu <liupan1111@gmail.com>
@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 10, 2025

/retest

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 10, 2025

@liupan1111: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Dec 10, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 10, 2025
@rleungx rleungx requested a review from JmPotato December 10, 2025 13:16
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 10, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-10 07:52:27.046326328 +0000 UTC m=+1027491.860103900: ☑️ agreed by rleungx.
  • 2025-12-10 14:34:11.008545836 +0000 UTC m=+1051595.822323408: ☑️ agreed by JmPotato.

@JmPotato
Copy link
Copy Markdown
Member

JmPotato commented Dec 10, 2025

/retest

@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 11, 2025

/retest-required

1 similar comment
@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 11, 2025

/retest-required

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Dec 11, 2025

/test pull-unit-test-next-gen-2

@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 11, 2025

/retest-required

@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 11, 2025

/test pull-unit-test-next-gen-2

1 similar comment
@liupan1111
Copy link
Copy Markdown
Contributor Author

liupan1111 commented Dec 11, 2025

/test pull-unit-test-next-gen-2

@ti-chi-bot ti-chi-bot Bot merged commit 6cebb33 into tikv:master Dec 11, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@rleungx rleungx rleungx approved these changes

+2 more reviewers

@ystaticy ystaticy ystaticy left review comments

@liyishuai liyishuai liyishuai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestTSOKeyspaceGroupSplitElection is flaky

5 participants

@liupan1111 @rleungx @JmPotato @ystaticy @liyishuai