Skip to content

client: fix tso service discovery (#9595) #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ti-chi-bot wants to merge 2 commits into
base: release-8.5
Choose a base branch
from
Open

client: fix tso service discovery (#9595) #10002

ti-chi-bot wants to merge 2 commits into from
+103 −40

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 5, 2025

This is an automated cherry-pick of #9595

What problem does this PR solve?

Issue Number: Close #9593.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 5, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 5, 2025
Merged
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 5, 2025

@rleungx This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 8, 2025
@rleungx
fix
63093cc 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx requested review from JmPotato and lhy1024 December 9, 2025 09:12
@rleungx
Copy link
Member

rleungx commented Dec 9, 2025

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.80%. Comparing base (0d0a253) to head (63093cc).
⚠️ Report is 13 commits behind head on release-8.5.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-8.5   #10002      +/-   ##
===============================================
+ Coverage        77.74%   77.80%   +0.06%     
===============================================
  Files              467      468       +1     
  Lines            62474    63134     +660     
===============================================
+ Hits             48570    49122     +552     
- Misses           10315    10394      +79     
- Partials          3589     3618      +29
Flag Coverage Δ
unittests 77.80% <90.32%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx
Copy link
Member

rleungx commented Dec 10, 2025

friendly ping @JmPotato @lhy1024

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-10 09:16:28.685084111 +0000 UTC m=+1032533.498861683: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees

@rleungx rleungx

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @rleungx @lhy1024