CheckNotExists is checked in the prewrite phase and should not appear in the commit phase.#316
Closed
gfreezy wants to merge 2 commits intotikv:masterfrom
Closed
CheckNotExists is checked in the prewrite phase and should not appear in the commit phase.#316gfreezy wants to merge 2 commits intotikv:masterfrom
gfreezy wants to merge 2 commits intotikv:masterfrom
Conversation
… in the commit phase. Signed-off-by: Alex.F <gfreezy@gmail.com>
gfreezy
force-pushed
the
fix-check-not-exists
branch
from
1d31029 to
3fe6267
Compare
Collaborator
|
The change itself looks good to me. I'd prefer to fix the primary key issue and add a test in the same PR to close #315 . |
Collaborator
|
Can we merge it now? |
Collaborator
|
I think a test case is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #315
@ekexium
CheckNotExistsis already checked when set primary key.