Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 9.x Shift #319

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Laravel 9.x Shift #319

wants to merge 16 commits into from

Conversation

vaughnjones-marcus
Copy link

This pull request includes the changes for upgrading to Laravel 9.x. Feel free to commit any additional changes to the shift-101902 branch.

Before merging, you need to:

  • Checkout the shift-101902 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, add --no-scripts)
  • Clear any config, route, or view cache
  • Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

@laravel-shift
Move resources/lang folder
e5d84d9
@laravel-shift
Shift registered middleware
6a15fe9
@laravel-shift
Remove fruitcake/laravel-cors dependency
99662d7
@laravel-shift
Streamline $commands property
d809edf
@laravel-shift
Replace deprecated HEADER_X_FORWARDED_ALL constant
483fc1d
@laravel-shift
Upgrade to Flysystem 3.0
9b4631a
@laravel-shift
Shift core files
616ef6f
@laravel-shift
Convert optional() to nullsafe operator
21d0fb7
@laravel-shift
Convert route options to fluent methods
ce9834f 
Laravel 8 adopts the tuple syntax for controller actions. Since the old options array is incompatible with this syntax, Shift converted them to use modern, fluent methods.
@laravel-shift
Adopt class based routes
fa9dfce
@laravel-shift
Shift config files
c302ef3
@laravel-shift
Default config files
4a519db 
In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.
@laravel-shift
Bump Laravel dependencies
7dab51e
@laravel-shift
Use <env> tags for configuration
aadb8de 
`<env>` tags have a lower precedence than system environment variables making it easier to overwrite PHPUnit configuration values in additional environments, such a CI.

Review this blog post for more details on configuration precedence when testing Laravel: https://jasonmccreary.me/articles/laravel-testing-configuration-precedence/
@laravel-shift
Set return type of base TestCase methods
d2d6f0d 
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type:

- `setUpBeforeClass()`
- `setUp()`
- `assertPreConditions()`
- `assertPostConditions()`
- `tearDown()`
- `tearDownAfterClass()`
- `onNotSuccessfulTest()`

[1]: https://phpunit.de/announcements/phpunit-8.html
@laravel-shift
Adopt anonymous migrations
7f972be
@vaughnjones-marcus
Copy link
Author

ℹ️ Shift noticed you have additional namespaces in your application. You may use the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel App namespace.

@vaughnjones-marcus
Copy link
Author

ℹ️ Laravel 9 moved the resources/lang folder to the top level of the project. While Shift moved and replaced references to this folder, you may have additional references to this folder which need to be updated.

@vaughnjones-marcus
Copy link
Author

⚠️ Laravel 9 transitioned from SwiftMailer to Symfony Mailer. While this transition should be relatively seamless and Shift automates any tedious changes, some changes may not reliably be automated.

Dependencies
Some mail providers may require an additional dependency. For example, if you are using Mailgun, then you will need to install the symfony/mailgun-mailer package:

composer require symfony/mailgun-mailer symfony/http-client

For more details on what has changed you may review the Symfony Mailer section of the Upgrade Guide.

@vaughnjones-marcus
Copy link
Author

⚠️ The FILESYSTEM_DRIVER environment variable was renamed to FILESYSTEM_DISK in Laravel 9. Shift did not find this variable referenced in your committed files, but you should review any additional environment configuration and rename this variable.

@vaughnjones-marcus
Copy link
Author

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 4a519db1 and make the config file changes manually.

@vaughnjones-marcus
Copy link
Author

ℹ️ The FILESYSTEM_CLOUD environment variable was removed in a later release of Laravel 8. While you may still use the cloud disk, you are encouraged to configure your own disks.

@vaughnjones-marcus
Copy link
Author

⚠️ The token driver for API authentication is no longer available. This driver was not very robust and was removed from the documentation. Laravel now recommends using Sanctum.

If you were using the token driver, you may re-add it within your auth.php configuration file then migrate to Sanctum at your convenience.

@vaughnjones-marcus
Copy link
Author

ℹ️ Shift updated your dependencies for Laravel 9. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 9. Watch dealing with dependencies for tips on handling any Composer issues.

@vaughnjones-marcus
Copy link
Author

ℹ️ Laravel 9 adopted anonymous migrations. Shift automated this change to align with modern Laravel conventions and avoid naming migrations.

@vaughnjones-marcus
Copy link
Author

ℹ️ All of the underlying Symfony components used by Laravel have been upgraded to Symfony 6. If you are directly interacting with any Symfony component, you should review the Symfony change log for additional changes.

@vaughnjones-marcus
Copy link
Author

ℹ️ The HTTP client has been updated to have a default timeout of 30 seconds. Previously there was no default. The underlying request would wait indefinitely. Now an exception is thrown after 30 seconds.

If you find your requests need longer, you may prefix your request to specify a timeout:

Http::timeout(60)->get("https://laravelshift.com");

@vaughnjones-marcus
Copy link
Author

ℹ️ Laravel 9 now uses Vite to build frontend assets. While you may continue to use Laravel Mix, it is no longer the default. If you wish to modernize your application to use Vite, you may run the Vite Converter for free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaughnjones-marcus @laravel-shift