Draft: Add variable definitions via let #110
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As came up in #104, i took a look at adding variable definitions via
let x = expr
.Still some things to figure out:
Right now, it's possible to set variables to names which then are inaccessible because they are masked by a unit with the same name.
I'd like to probably change lookup slightly so it also returns the type of the lookup result, so before setting a variable, we can check whether there already is something other than a variable with this name and refuse. I think silently redefining variables with another
let
is fine, though.Again, any thoughts or ideas are appreciated :)