Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tier4_metric_msgs #149

Merged
merged 4 commits into from
Nov 12, 2024
Merged

feat: tier4_metric_msgs #149

merged 4 commits into from
Nov 12, 2024

Conversation

xtk8532704
Copy link
Contributor

@xtk8532704 xtk8532704 commented Oct 29, 2024

Related Links

Discussion on slack about Metric_msgs: https://star4.slack.com/archives/C4P0NSMB5/p1725255842890819

related PR of universe side: autowarefoundation/autoware.universe#9180
related Ticket: https://tier4.atlassian.net/browse/RT1-6863

Description

This PR introduces a new tier4_metric_msgs package that contains Metric.msg and MetricArray.msg for the autoware system's evaluation metrics. It aims to replace the DiagnosticArray/DiagnosticState misused in the system to transmit metric information.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtk8532704
Copy link
Contributor Author

@yukkysaito Can you merge this PR.

@yukkysaito yukkysaito merged commit 93259c2 into tier4/universe Nov 12, 2024
10 checks passed
@yukkysaito yukkysaito deleted the xtk/metric-msg branch November 12, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants