Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cyclonedds #121

Merged
merged 1 commit into from
Sep 20, 2023
Merged

feat: added cyclonedds #121

merged 1 commit into from
Sep 20, 2023

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Sep 19, 2023

Description

Since version v0.10.x of cyclonedds, function hooks are no longer possible due to the addition of a description that hides symbols. Include Cyclone DDS in ros2_caret_ws and disable certain descriptions in order to be able to hook Cyclone DDS functions.

  • Directories:
└── src
    ├── CARET
    ├── eclipse-cyclonedds
    ├── ros-tracing
    └── ros2
  • How to disable symbol hiding process
    • Just comment out set_property(TARGET ddsc PROPERTY C_VISIBILITY_PRESET hidden)

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yamasaki <[email protected]>
Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caret: v0.4.15
cyclonedds: ros-humble-cyclonedds 0.10.3-1

$ sudo apt policy ros-humble-cyclonedds
ros-humble-cyclonedds:
  Installed: 0.10.3-1jammy.20230822.172333
  Candidate: 0.10.3-1jammy.20230822.172333
  Version table:
 *** 0.10.3-1jammy.20230822.172333 500
        500 http://packages.ros.org/ros2/ubuntu jammy/main amd64 Packages
        100 /var/lib/dpkg/status

I have confirmed that dds_wreite paths can be measured with cycloneddss 0.10.x in the above environment.
Original cyclonedds installed by apt are not used as intended.
LGTM 👍

image

@ymski ymski merged commit 869d205 into tier4:main Sep 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants