feat: interactive calibrator - new api#179
Conversation
vividf
left a comment
There was a problem hiding this comment.
LGTM!
Test that the sensor_calibration_manager is able to launch the calibrator in the default project.
|
*Tested |
|
@knzo25 got it! |
|
@vividf ? |
…d fixed some bugs Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
1cf3e2b to
357dced
Compare
vividf
left a comment
There was a problem hiding this comment.
I run the interactive calibrator in the default project with the camera_lidar.db3 rosbag provided in the pnp tutorial.
However, camera image didn't show up in the UI and the pointcloud didn't show up in the rviz2.
Could you provide more detail information how you test this PR?
| Filter size: 10 | ||
| History Policy: Keep Last | ||
| Reliability Policy: Best Effort | ||
| Value: /sensing/lidar/concatenated/pointcloud |
There was a problem hiding this comment.
Please change the default value to the input pointcloud instead of the concatenated pointcloud
Description
This should be reviewed after the documentation gets merged (and rebased before merged)
It is has little to no priority compared with other calibration tools tasks
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.