Skip to content

tdd2025 post #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

tdd2025 post #742

wants to merge 7 commits into from

Conversation

topepo
Copy link
Member

@topepo topepo commented Jun 24, 2025

No description provided.

@topepo topepo mentioned this pull request Jun 24, 2025
19 tasks
@topepo topepo requested review from hadley and lionel- June 24, 2025 15:40

## Who should attend

You should attend if:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of admire the breezy tone here, but worry that if someone takes this at face value, they might show up effectively needing 1-on-1 help for the entire day. I think getting an R package dev environment set up in advance (or at least trying very hard to do so) is basically a pre-req. I would mention the Git/GitHub workshop that @mine-cetinkaya-rundel will run as recommended prep for folks who've never made a PR before.

Copy link
Member

@mine-cetinkaya-rundel mine-cetinkaya-rundel Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can say something like: "Leading up to TDD, we will hold (optional) virtual "office hours" for TDD participants to help you with your Git workflow so that you can stroll into TDD confident that your R, Git, GitHub, and IDE are set up in the most ideal way possible to work in harmony on your laptop."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we could be a little less breezy and change it to "A genuine desire to learn the basics of package development", and then maybe add "A GitHub" account as a prereq (along with a pointer to Mine's office hours)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually maybe we could just remove this bulleted list and use the paragraph below?

Co-authored-by: Jennifer (Jenny) Bryan <[email protected]>

## Who should attend

You should attend if:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we could be a little less breezy and change it to "A genuine desire to learn the basics of package development", and then maybe add "A GitHub" account as a prereq (along with a pointer to Mine's office hours)


## Who should attend

You should attend if:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually maybe we could just remove this bulleted list and use the paragraph below?

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you just need to run hugodown::use_tidy_thumbnails() to shrink the thumbnail sizes

@topepo
Copy link
Member Author

topepo commented Jul 16, 2025

I'll update and merge after dinner!

@hadley
Copy link
Member

hadley commented Jul 16, 2025

@topepo can you please hold off for a day or two? Want to make sure @hfrick has a chance to give feedback on the dietary restrictions info we're collecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants