Facet: new method setup_panel_params to interact panel_params#6397
Merged
teunbrand merged 3 commits intotidyverse:mainfrom Apr 9, 2025
Merged
Facet: new method setup_panel_params to interact panel_params#6397teunbrand merged 3 commits intotidyverse:mainfrom
Facet: new method setup_panel_params to interact panel_params#6397teunbrand merged 3 commits intotidyverse:mainfrom
Conversation
teunbrand
reviewed
Apr 8, 2025
teunbrand
approved these changes
Apr 8, 2025
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
Aside from the one suggestion, this looks good to me. Do you want to add a news bullet?
Co-authored-by: Teun van den Brand <49372158+teunbrand@users.noreply.github.com>
Author
|
Thanks for the reiviewing |
Collaborator
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6380
This commit just add new method
setup_panel_paramsinFacetobject, and letFacetcan act with thepanel_paramssetted byCoordobject before drawing.