Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explicitly state how to change DuckDB configuration options #587

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Feb 6, 2025

Fix #485

@maelle maelle requested a review from krlmlr February 6, 2025 09:29
@maelle maelle mentioned this pull request Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2b43bfa is merged into main:

  • ✔️001_tpch_01: 23.7ms -> 23.6ms [-5.48%, +4.14%]
  • ✔️001_tpch_02: 64.1ms -> 64.4ms [-1.66%, +2.52%]
  • ✔️001_tpch_03: 39.4ms -> 39.6ms [-2.02%, +3.12%]
  • ✔️001_tpch_04: 27.7ms -> 27.9ms [-0.57%, +2.21%]
  • ✔️001_tpch_05: 57.8ms -> 58.2ms [-1.34%, +2.53%]
  • ❗🐌001_tpch_06: 11.6ms -> 12.1ms [+0.03%, +8.47%]
  • ✔️001_tpch_07: 72.9ms -> 71.7ms [-3.38%, +0.12%]
  • ✔️001_tpch_08: 97.5ms -> 97.8ms [-1.37%, +2.14%]
  • ✔️001_tpch_09: 69.2ms -> 69.5ms [-1.73%, +2.68%]
  • ✔️001_tpch_10: 48.7ms -> 48.4ms [-2.94%, +1.45%]
  • ✔️001_tpch_11: 38.1ms -> 38.3ms [-1.33%, +2.46%]
  • ✔️001_tpch_12: 21.2ms -> 21.1ms [-2.76%, +1.87%]
  • ✔️001_tpch_13: 18.1ms -> 17.9ms [-3.48%, +0.49%]
  • ✔️001_tpch_14: 16.6ms -> 16.8ms [-1.35%, +3.31%]
  • ✔️001_tpch_15: 36.9ms -> 36.9ms [-2.72%, +2.91%]
  • ✔️001_tpch_16: 37.3ms -> 37.2ms [-2.36%, +1.93%]
  • ✔️001_tpch_17: 31.7ms -> 31.8ms [-3.02%, +3.45%]
  • ✔️001_tpch_18: 28.5ms -> 28ms [-4.19%, +0.48%]
  • ✔️001_tpch_19: 37.9ms -> 37.8ms [-1.58%, +0.77%]
  • 🚀001_tpch_20: 55ms -> 53.5ms [-5.17%, -0.46%]
  • ✔️001_tpch_21: 83.6ms -> 83.8ms [-1.98%, +2.41%]
  • ✔️001_tpch_22: 46.1ms -> 46.5ms [-1.33%, +2.81%]
  • ❗🐌010_tpch_01: 83.2ms -> 85.8ms [+0.36%, +5.78%]
  • ✔️010_tpch_02: 72.6ms -> 72.7ms [-2.37%, +2.79%]
  • ✔️010_tpch_03: 59.4ms -> 60.2ms [-4.07%, +6.69%]
  • ✔️010_tpch_04: 43.3ms -> 42.9ms [-3.81%, +1.93%]
  • ✔️010_tpch_05: 89.4ms -> 90ms [-1.86%, +3.3%]
  • ✔️010_tpch_06: 28.5ms -> 28.9ms [-5.39%, +8%]
  • ✔️010_tpch_07: 102ms -> 104ms [-0.28%, +4.42%]
  • ✔️010_tpch_08: 127ms -> 126ms [-2.27%, +1.03%]
  • ✔️010_tpch_09: 117ms -> 116ms [-3.1%, +1.68%]
  • ✔️010_tpch_10: 74.1ms -> 74.5ms [-1.8%, +2.72%]
  • ✔️010_tpch_11: 38.3ms -> 37.8ms [-4.62%, +1.93%]
  • ✔️010_tpch_12: 50.9ms -> 50.2ms [-5.6%, +2.57%]
  • ✔️010_tpch_13: 51.2ms -> 50.2ms [-7.86%, +4.02%]
  • ✔️010_tpch_14: 33.5ms -> 33.3ms [-2.8%, +2.09%]
  • ✔️010_tpch_15: 53.2ms -> 50.4ms [-12.28%, +1.96%]
  • ✔️010_tpch_16: 38.7ms -> 38.3ms [-3.5%, +1.58%]
  • ✔️010_tpch_17: 54.3ms -> 52.6ms [-9.39%, +3.4%]
  • ✔️010_tpch_18: 53.8ms -> 53.5ms [-8.32%, +7.01%]
  • ✔️010_tpch_19: 83.5ms -> 83.7ms [-1.89%, +2.42%]
  • ✔️010_tpch_20: 65.7ms -> 64.3ms [-6.57%, +2.55%]
  • ✔️010_tpch_21: 245ms -> 248ms [-1%, +3.54%]
  • ✔️010_tpch_22: 53.5ms -> 54ms [-1.4%, +3.18%]
  • ✔️100_tpch_01: 377ms -> 379ms [-0.48%, +1.25%]
  • ✔️100_tpch_02: 129ms -> 124ms [-13.36%, +4.96%]
  • ✔️100_tpch_03: 173ms -> 168ms [-9.68%, +4.59%]
  • ✔️100_tpch_04: 150ms -> 148ms [-8.72%, +5.57%]
  • ✔️100_tpch_05: 269ms -> 271ms [-12.41%, +14.15%]
  • ✔️100_tpch_06: 98.3ms -> 95.8ms [-20.47%, +15.34%]
  • ✔️100_tpch_07: 225ms -> 220ms [-12.28%, +7.58%]
  • ✔️100_tpch_08: 272ms -> 263ms [-13.52%, +6.77%]
  • ✔️100_tpch_09: 327ms -> 335ms [-2.04%, +7%]
  • ✔️100_tpch_10: 214ms -> 216ms [-4.26%, +5.64%]
  • ✔️100_tpch_11: 95.4ms -> 87ms [-28.32%, +10.74%]
  • ✔️100_tpch_12: 178ms -> 184ms [-5.69%, +11.92%]
  • ✔️100_tpch_13: 327ms -> 324ms [-4.99%, +3.46%]
  • ✔️100_tpch_14: 113ms -> 123ms [-0.36%, +17.55%]
  • ✔️100_tpch_15: 196ms -> 208ms [-5.43%, +17.5%]
  • ✔️100_tpch_16: 121ms -> 119ms [-6.15%, +2.59%]
  • ✔️100_tpch_17: 178ms -> 195ms [-4.4%, +23.23%]
  • ✔️100_tpch_18: 193ms -> 194ms [-13.35%, +14.77%]
  • ✔️100_tpch_19: 260ms -> 264ms [-16.56%, +19.95%]
  • ✔️100_tpch_20: 170ms -> 177ms [-8.18%, +17.15%]
  • ✔️100_tpch_21: 1.34s -> 1.33s [-3.95%, +3.2%]
  • ✔️100_tpch_22: 148ms -> 150ms [-3.38%, +6.4%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr
Copy link
Member

krlmlr commented Feb 7, 2025

Will tweak locally and merge.

@krlmlr krlmlr enabled auto-merge (squash) February 7, 2025 03:32
@krlmlr
Copy link
Member

krlmlr commented Feb 7, 2025

Thanks!

@krlmlr krlmlr merged commit 293ad41 into main Feb 7, 2025
6 checks passed
@krlmlr krlmlr deleted the db-exec branch February 7, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DuckDB configuration
2 participants