Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): adding showcancel property #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akansha-maheshwari
Copy link
Contributor

https://jira.appcelerator.org/browse/MOD-1867

Adding default-overlay.js file to show default cancel behavior.

@build
Copy link

build commented Jul 3, 2020

Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 146 tests are passing.

📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against 5379284

@jquick-axway
Copy link
Contributor

@akansha-maheshwari-axway, the files under the following folders were not made by us.

  • ./android/src/com/google/zxing/client/android
  • ./android/platform/android/res

We copied the above file trees from the open source "zxing" repo below. Note that this open source project does not offer an AAR which means its res files have to be copied over to our project. Also, not all of its source code is provided by the zxing JARs which is why we have to copy the open source project's Java source tree to this repo.
https://github.com/zxing/zxing/tree/master/android

This means the edits you are making to these folders may end up being lost the next time we update this module with the newest zxing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants