appcd-default-plugins v4 #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t plugins at runtime to avoid user permissions. chore(appcd-default-plugins): v4.0.0
ewanharris
reviewed
Jul 1, 2019
fix: Properly handle file permission errors. fix: Add support for installed plugins.
|
@ewanharris I refactored things and I think I've come up with a viable hack to get the default plugins installed. What do you think? Assuming the default plugins where successfully installed at Also, any idea why Jenkins is not liking |
|
@cb1kenobi, I don't think it's Jenkins not liking it, it seems like a genuine bug in the dev flow with this change. To repro
And you'll get the error above, basically it tries to run the postinstall step after it's installed/linked all modules but before it's built the sources so 💥 . I guess maybe we need a short circuit? |
…uld fail if gulp build hasn't been run when working from the monorepo.
chore: Fixed eslint warnings.
…>=8.0.0 to >=8.1.0 to fix issue where 8.0.x didn't support 'async_hooks.createHook()', yet appcd-util was using it. chore(gulp): Updated to [email protected] which added eslint 6 support and added Node.js eslint rules.
fix(telemetry): Fixed live config changes for environment name. fix(request): Fixed request config setting precedence such that environment variables override config settings. fix(core): Fixed bug where 'server.hostname' was not being correctly referenced.
|
Closing due to restructure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until appcelerator-archive/appc-daemon-plugins#9 has been merged
postinstallpackage.jsonhas version that is not installedBREAKING CHANGE(appcd-default-plugins): Switched to installing default plugins at runtime to avoid user permissions.
chore(appcd-default-plugins): v4.0.0
https://jira.appcelerator.org/browse/DAEMON-280
appcd statusshows the registered plugins: