New features usefull for sollar panels/home battery owners#114
New features usefull for sollar panels/home battery owners#114voroniys wants to merge 20 commits intotibber:mainfrom
Conversation
|
Thanks for contributing! From an initial look, you've definitely added some useful things here. This is big enough a contribution that we want to try this out a bit on our Homeys we think, but we can start reviewing parts of it still. We'll try to do a "mob review" (we'll be friendly though!) this week. |
jstaro
left a comment
There was a problem hiding this comment.
I think we need to know your use cases a little more in-depth because this is quite a lot of new stuff added in one go.
First of all, what market are you in? We're a bit reluctant to start exposing prices without tax (can easily get a bit messy) unless there's a real and clear benefit. You wrote something about faster reacting automations?
The negative price trigger, does that really need to be its own trigger or can't you just use the normal price changed trigger and do your logic on that, or is the fact that it's triggering on negative spot price without tax a real benefit here? It's unclear to us, but we might be in different markets where things work differently reward/cost-wise.
Is the main use case to, say, turn off your inverter during these periods, or to turn on other loads to prevent export?
Great stuff with including production and reward in the so-called daily consumption report.
Also we wonder a little bit if all these lowest/highest/average capabilities could just be trigger tokens instead?
.homeycompose/capabilities/negative_energy_price_time_left.json
Outdated
Show resolved
Hide resolved
|
@jstaro Are you still interested in looking into this PR? |
|
@voroniys |
Prices are already stored in memory and compared with up to 4 decimals for triggering purposes, right? We're also thinking that the number of decimals could be set automatically on pairing the home device depending on the currency of your home subscription. You seem to like up to 4 though. With that many, we would probably need a user setting or Norwegians and Swedes could become unhappy. We're a bit concerned that adding all these parallel price capabilities will make it pretty difficult to maintain the app. If we'll do it, we'll have to think of really good naming here, and it's unfortunate that we have this old internal name But we're wondering if your use case(s) cannot be supported by an opt-in advanced setting on the home? Like a home device setting (off by default) to not include the tax/fees (works a bit differently in different markets) part of the price and use pure spot prices and then we'll just switch between checking/emitting If not, I think we need to do a more thorough review and perhaps do a bit of refactoring/restructuring because it's a bit hard to follow right now (not necessarily the fault of this PR, but the preexisting code). |
|
The driver capabilities are rounded to 2 decimals. But mine issue is that capabilities are not only for presentations. Any capability is becoming a tag available to use in logic app for instance, or in homeyscripts. And here this rounding becomes an issue and that is why I've created hidden capabilities, not presented in UI, but available as tags for other apps and/or homeysript. And that is why I want to use netto energy price without rounding. I'm mostly using them outside this app in homeyscripts. The same is also true for such hidden capabilities, like remaining time of negative prices. It is used in calculations in homeyscripts to adjust some parameters of hybrid inverter. The fact that conditions inside app use not rounded values is not enough. In my flows I'm using a lot (advanced)logic app as well as homescript and all this external usages are based on rounded capabilities values which is not really convenient. In this PR the changes to the Pulse driver are mostly for the nicer presentation layer - to show both usage and production and generate nicer report at the end of the day. But changes to home driver as you can see are mostly intended to give extra tags available to external usage outside the Tibber app. Of course all these changes are only useful for advanced users, who is using advanced flows and only refers to the capabilities tags provided by this app as input. That is why these capabilities are hidden from UI - they are not intended for presentation, they are aimed for automation. Of course all my changes are very much specific to the Dutch market that is why I tried to not interfere too much with the current functionality and I just extended it with new features and hidden capabilities that are only available as tags for external use in automation flows. Presentation changes I've made to my mind should be useful for any market - such as display not only current, bat also min/max/avg prices in Home driver and production/saldo in pulse driver. IMHO this extra information would be useful for everyone in any country. Of course they are only useful for users who has solar panels and/or home battery. If you think it would be useful I can add a setting to have a possibility to switch these capabilities off from the presentation layer for users without production facilities. It is also possible to create opt-in setting for all those extra hidden capabilities in Home driver, but IMHO this will only add unnecessary complexity - as these capabilities are hidden and not present in UI they are never will confuse anyone. They are only visible as tags for those who uses advanced flow automation. |
Make possible to work with 15 min slots instead of hours The triggers/conditions like "for the next N hours" lrft as is, but hours is internally re-calculated to quarter slots. The triggers/conditions like "among N lowest/hghest prices" is changed to "among N lowest/highest slots"
|
@jstaro I've updated this PR by adding the possibility to work with 15 min slots instead of hours (this quarter electricity prices are active on a Dutch market since 1 October) |
Hi Tibber,
I'm a Tibber customer and therefore using Tibber Homey App in a lot of Flows I have at home.
So I decided to create a PR - may be you'll be willing to include these changes to main version.
What I've added:
Home driver:
Pulse driver:
The App with all these changes is successfully running on my Homey Pro 2023 model and I'm quite happy with it. Hope you can make other users as happy as I'm :)
And I'm still working on some more advanced functionality which I'm missing in my advanced flows. So probably this is not the last PR :)