Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for --no-timeout and compiler warnings #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixes for --no-timeout and compiler warnings #45

wants to merge 7 commits into from

Conversation

jefflasslett
Copy link
Contributor

--no-timeout seemed to only prevent the display of the timeout progress indicator. It didn't actually prevent the timeout.

Also eliminated some compiler warnings.

Jeff Lasslett added 7 commits January 9, 2013 16:54
Eliminate warning about deleting instance where object's base class h…
ee2381b 
…as non-virtual descructor
Eliminate warnings pertaining to unused 'dummy' vars
11c43c8
Prevent timeout exit when --no-timeout is used
541f4b6
Remove tab chars to correct indentation
009bf5c
Fix issue where calibration values for rotated screen were wrong
2bc5f58 
I think this commit fixes the issue reported by Tokoyami.  Calibration
values were really wrong.  The issue seemed to be caused by the commits
bfeaf2e (which is a broken commit) and 07978b9.  git-bisect told me
this.

Also removed duplication of calibration code "finish()" between evdev.cpp
and calibrator.cpp.  Added "compensateForDevice()" virtual function to
handle adjustments needed to compensate for the device.
Rewrite xf86ScaleAxis in terms of scaleAxis
a97bbc0 
Also, explicitly use double types in calibration calculations.  Due to the
use of fp constants without a suffix, double was always the type within the
scaling arithmetic anyway.
Ensure that calibration values are in the right order when axes are s…
14a682d 
…wapped
@jefflasslett
Copy link
Contributor Author

I've also fixed a few problems with the calibrator now. Calibrates properly when axes swapping is required. I've removed some code duplication too.

@ghost ghost mentioned this pull request Feb 3, 2013
Open
@schnitzeltony schnitzeltony mentioned this pull request Feb 5, 2013
Merged
@tias
Copy link
Owner

tias commented Feb 7, 2013

Thanks, I have to look into the fix in more detail.

The problem is that the behaviour of the evdev driver changed, so depending on your evdev version you will either fix or break it...

@tias
Copy link
Owner

tias commented Feb 7, 2013

Can you tell me what version of evdev you are running? Thanks

@jefflasslett
Copy link
Contributor Author

Hi Tias,

Sorry for the late reply.
Here's an excerpt from my /var/log/Xorg.0.log:

14.544 Module evdev: vendor="X.Org Foundation"
[ 14.544] compiled for 1.13.0, module version = 2.7.3
[ 14.544] Module class: X.Org XInput Driver
[ 14.544] ABI class: X.Org XInput driver, version 18.0

Looks like 2.7.3

Cheers,
Jeff

On 8 February 2013 07:41, Tias Guns [email protected] wrote:

Can you tell me what version of evdev you are running? Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/45#issuecomment-13258409.

@schnitzeltony schnitzeltony mentioned this pull request Feb 14, 2013
Merged
ramok pushed a commit to ramok/xinput_calibrator that referenced this pull request Mar 4, 2015
@schnitzeltony
Prevent timeout exit when --no-timeout is used
c4d1e11 
Submitted tias#45

Signed-off-by: Jeff Lasslett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jefflasslett @tias