Skip to content

ArmPkg: Remove unused variable #11794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2025
Merged

ArmPkg: Remove unused variable #11794

merged 2 commits into from
Nov 25, 2025
+0 −5

Conversation

@mikebeaton
Copy link
Member

@mikebeaton mikebeaton commented Nov 24, 2025 •
edited
Loading

Description

Remove unused variable caught by clang builds.

  • Breaking change?
    • NO.
  • Impacts security?
    • NO.
  • Includes tests?
    • NO.

How This Was Tested

Re-build, then re-run CI.

Integration Instructions

N/A

@mikebeaton
ArmPkg: Remove unused variable
89cf9a2 
Remove unused variable caught by clang builds.

Signed-off-by: Mike Beaton <[email protected]>
@mikebeaton mikebeaton marked this pull request as draft November 24, 2025 12:16
@mikebeaton mikebeaton mentioned this pull request Nov 25, 2025
Merged
@mikebeaton mikebeaton marked this pull request as ready for review November 25, 2025 01:42
@mikebeaton
Copy link
Member Author

mikebeaton commented Nov 25, 2025

Anyone like the look of this? Sorry these are coming in dribs and drabs. This is, at least, the only outstanding one required to make ArmPkg itself compile under XCODE5, at the moment.

@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Nov 25, 2025
@mergify
Copy link

mergify bot commented Nov 25, 2025 •
edited
Loading

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 8 minutes 49 seconds in the queue, including 8 minutes 40 seconds waiting for CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = tianocore.PatchCheck
    • check-neutral = tianocore.PatchCheck
    • check-skipped = tianocore.PatchCheck
  • any of [🛡 GitHub branch protection]:
    • check-success = ArmVirtPkg - Ubuntu GCC - PR
    • check-neutral = ArmVirtPkg - Ubuntu GCC - PR
    • check-skipped = ArmVirtPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = EmulatorPkg - Ubuntu GCC - PR
    • check-neutral = EmulatorPkg - Ubuntu GCC - PR
    • check-skipped = EmulatorPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = EmulatorPkg - Windows VS - PR
    • check-neutral = EmulatorPkg - Windows VS - PR
    • check-skipped = EmulatorPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = OvmfPkg - Ubuntu GCC - PR
    • check-neutral = OvmfPkg - Ubuntu GCC - PR
    • check-skipped = OvmfPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = OvmfPkg - Windows VS - PR
    • check-neutral = OvmfPkg - Windows VS - PR
    • check-skipped = OvmfPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = Windows VS - PR
    • check-neutral = Windows VS - PR
    • check-skipped = Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = Ubuntu GCC - PR
    • check-neutral = Ubuntu GCC - PR
    • check-skipped = Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate Pull Request Formatting
    • check-neutral = Validate Pull Request Formatting
    • check-skipped = Validate Pull Request Formatting

@mergify mergify bot added the queued label Nov 25, 2025
@mergify mergify bot merged commit 6e5835d into tianocore:master Nov 25, 2025
117 checks passed
@mergify mergify bot removed the queued label Nov 25, 2025
@mikebeaton mikebeaton deleted the mmcpei-unused branch November 29, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardbiesheuvel ardbiesheuvel ardbiesheuvel approved these changes

@leiflindholm leiflindholm Awaiting requested review from leiflindholm

@samimujawar samimujawar Awaiting requested review from samimujawar

@vishalo vishalo Awaiting requested review from vishalo

Assignees

No one assigned

Labels

push Auto push patch series in PR if all checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikebeaton @ardbiesheuvel