-
Notifications
You must be signed in to change notification settings - Fork 3k
.pytool/HostUnitTestCompilerPlugin: Return failure if dsc path is not… #11763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.pytool/HostUnitTestCompilerPlugin: Return failure if dsc path is not… #11763
Conversation
950b3c1 to
24c3591
Compare
|
@mdkinney please help to review this. thanks. |
|
@cosmolai Please update the PR description, putting the main comments under the Thanks, |
.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
Outdated
Show resolved
Hide resolved
24c3591 to
772e74a
Compare
Pull Request Formatting Issues
Address these issues and the validation will automatically re-run when you update your pull request. |
Updated. Let me know if any. |
|
Approved. Will give it the weekend for others to review if they wish. Then will add the push tag. Thank you for the contribution! |
|
@cosmolai please rebase this commit on main and force push. I am unable from the github UI, so there may be a conflict that needs resolved. This should allow the PR to be queued for merge. Thanks! |
… valid The HostUnitTestCompilerPlugin currently skips the package if the dsc path described in .ci.yaml is not valid. This change returns failure if dsc path is not valid. Signed-off-by: Cosmo Lai <[email protected]>
772e74a to
1188996
Compare
Description
The HostUnitTestCompilerPlugin currently skips the package if the dsc path described in .ci.yaml is not valid.
This change returns failure if dsc path is not valid.
How This Was Tested
Verified if returns skipped if dsc path is empty.
Verified it returns failure if dsc path is not valid.
Integration Instructions
N/A