Skip to content

Conversation

@cosmolai
Copy link
Contributor

@cosmolai cosmolai commented Nov 17, 2025

Description

The HostUnitTestCompilerPlugin currently skips the package if the dsc path described in .ci.yaml is not valid.
This change returns failure if dsc path is not valid.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Verified if returns skipped if dsc path is empty.
Verified it returns failure if dsc path is not valid.

Integration Instructions

N/A

@cosmolai cosmolai force-pushed the return_error_if_dsc_not_valid branch from 950b3c1 to 24c3591 Compare November 17, 2025 04:27
@cosmolai cosmolai marked this pull request as ready for review November 17, 2025 05:57
@cosmolai
Copy link
Contributor Author

@mdkinney please help to review this. thanks.

@Javagedes
Copy link
Contributor

@cosmolai Please update the PR description, putting the main comments under the ## Description section, and filling out the rest of the sections.

Thanks,
Joey

@cosmolai cosmolai force-pushed the return_error_if_dsc_not_valid branch from 24c3591 to 772e74a Compare November 18, 2025 04:00
@tianocore-pr-automation
Copy link

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Include a description of the change and why this change was made._>
<_For each item, place an "x" in between [and]if true. Example:[x] (you can also check items in GitHub UI)_>
<_Create the PR as a Draft PR if it is only created to run CI checks._>
<_Delete lines in \<\> tags before creating the PR._>
<_Describe the test(s) that were run to verify the changes._>
<_Describe how these changes should be integrated. Use N/A if nothing is required._>

Address these issues and the validation will automatically re-run when you update your pull request.

@cosmolai
Copy link
Contributor Author

@cosmolai Please update the PR description, putting the main comments under the ## Description section, and filling out the rest of the sections.

Thanks, Joey

Updated. Let me know if any.

@Javagedes
Copy link
Contributor

Approved. Will give it the weekend for others to review if they wish. Then will add the push tag. Thank you for the contribution!

@Javagedes Javagedes added the push Auto push patch series in PR if all checks pass label Nov 25, 2025
@mergify
Copy link

mergify bot commented Nov 25, 2025

Merge Queue Status Beta

🚫 The pull request has left the queue (rule: default)

This pull request spent 5 seconds in the queue, with no time waiting for CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/BuildPlatform.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Javagedes
Copy link
Contributor

@cosmolai please rebase this commit on main and force push. I am unable from the github UI, so there may be a conflict that needs resolved. This should allow the PR to be queued for merge.

Thanks!

… valid

The HostUnitTestCompilerPlugin currently skips the package if the dsc path
described in .ci.yaml is not valid.

This change returns failure if dsc path is not valid.

Signed-off-by: Cosmo Lai <[email protected]>
@cosmolai cosmolai force-pushed the return_error_if_dsc_not_valid branch from 772e74a to 1188996 Compare November 25, 2025 16:29
@mergify mergify bot removed the dequeued label Nov 25, 2025
@mergify
Copy link

mergify bot commented Nov 25, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 1 hour 14 minutes 49 seconds in the queue, including 1 hour 14 minutes 39 seconds waiting for CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = tianocore.PatchCheck
    • check-neutral = tianocore.PatchCheck
    • check-skipped = tianocore.PatchCheck
  • any of [🛡 GitHub branch protection]:
    • check-success = ArmVirtPkg - Ubuntu GCC - PR
    • check-neutral = ArmVirtPkg - Ubuntu GCC - PR
    • check-skipped = ArmVirtPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = EmulatorPkg - Ubuntu GCC - PR
    • check-neutral = EmulatorPkg - Ubuntu GCC - PR
    • check-skipped = EmulatorPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = EmulatorPkg - Windows VS - PR
    • check-neutral = EmulatorPkg - Windows VS - PR
    • check-skipped = EmulatorPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = OvmfPkg - Ubuntu GCC - PR
    • check-neutral = OvmfPkg - Ubuntu GCC - PR
    • check-skipped = OvmfPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = OvmfPkg - Windows VS - PR
    • check-neutral = OvmfPkg - Windows VS - PR
    • check-skipped = OvmfPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = Windows VS - PR
    • check-neutral = Windows VS - PR
    • check-skipped = Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = Ubuntu GCC - PR
    • check-neutral = Ubuntu GCC - PR
    • check-skipped = Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate Pull Request Formatting
    • check-neutral = Validate Pull Request Formatting
    • check-skipped = Validate Pull Request Formatting

@mergify mergify bot added the queued label Nov 25, 2025
@mergify mergify bot merged commit 2f64496 into tianocore:master Nov 25, 2025
117 checks passed
@mergify mergify bot removed the queued label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

push Auto push patch series in PR if all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants