DynamicTablesPkg: AcpiMadtLibArm: Correct value of GICC.GICRBaseAddress #10709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the ACPI 6.5 specification (https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#gic-cpu-interface-gicc-structure) : "If all of the GIC Redistributors are in the always-on power domain, GICR structures should be used to describe the Redistributors instead, and this field must be set to 0." To comply with this statement, zero GICC.GICRBaseAddress when GICR structures are present in the MADT. Signed-off-by: Sarah Walker <[email protected]>
sarah-walker-arm
force-pushed
the
1481_GICC_GICR_v1
branch
from
d878791 to
0247f29
Compare
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
leiflindholm,
pierregondois and
samimujawar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From the ACPI 6.5 specification
(https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#gic-cpu-interface-gicc-structure) :
"If all of the GIC Redistributors are in the always-on power domain, GICR structures should be used to describe the Redistributors instead, and this field must be set to 0."
To comply with this statement, zero GICC.GICRBaseAddress when GICR structures are present in the MADT.
How This Was Tested
Manual comparison of acpiview output.
Integration Instructions
N/A